[Date Index][Thread Index]
[Date Prev][Date Next][Thread Prev][Thread Next]
there's still a bug in wml::des::navbar
- From: Gerd Maier <nospam@thanx>
- Date: Fri, 19 May 2000 11:02:01 +0200
Hi!
In WML 2.0.0 there still is a bug in the navbar-module, I know from the
wml-package in Debian slink (wml 1.6.something):
the target set in <navbar:define> isn't used, or -more exact- it is
overwritten by either the target set in <navbar:button> (which is normal)
or an empty string, if there's no target in <navbar:button>.
Gerd.
I appended a patch, which corrects this bug. I hope this is the right place
for it, but as even "wmb" sends its bugreports here, I think it is.
--- navbar.wml.orig Thu May 18 16:06:36 2000
+++ navbar.wml Fri May 19 09:40:55 2000
@@ -402,7 +402,6 @@
my @imgstar = split(':', $CFG->{IMGSTAR});
my $imgbase = $CFG->{IMGBASE};
my $urlbase = $CFG->{URLBASE};
- my $target = $CFG->{TARGET};
my $urlopts = $CFG->{URLOPTS};
$txtcol_n = $CFG->{TXTCOL_N} if $txtcol_n eq '';
$txtcol_s = $CFG->{TXTCOL_S} if $txtcol_s eq '';
@@ -432,7 +431,7 @@
my $alt = $B->{ALT};
my @img = split(':', $B->{IMG});
my $url = $B->{URL};
- my $target = $B->{TARGET};
+ my $target = ($B->{TARGET} eq '') ? $CFG->{TARGET} : $B->{TARGET};
my $hint = $B->{HINT};
my $menu = $B->{MENU};