Re: [wml] Re: [ANNOUNCE] WML 2.0.2

[Denis Barbier <nospam@thanx>]

On Fri, Jun 23, 2000 at 08:49:15PM +0200, Fritz Zaucker wrote:

> Some comments:
> 
> 1) I figured out the problem with <if ...> reported earlier. I think
>    there should be some more examples in the documentation.
> 
> 2) The following did work in 1.7.4 and not anymore:
> 
>    <define-tag TITLE>
>    ..!TITLE>>Something here<<..
>    </define-tag>
> 
>    <<TITLE>>
> 
>    Now one must use <<TITLE*>> instead. Seems to make sense, but is
>    somewhat of a trap while migrating.

No, since WML 1.7.3 it is recommended to write {#TITLE#} to prevent
problems with pass 2. Oh shit wml_intro(7) mentions both syntaxes.
All references to ..>>, <<.. and <<NAME>> must be removed from
documentation, except a note in wml_p5_divert.

> 3) This doesn't work anymore either (leads to a segmentation fault):
> 
>    <define-tag MYTAG>
>    Whatever
>    </define-tag MYTAG>
> 
>    You mustn't have an argument in the closing tag.

Sure, but mp4h mustn't segfault :(
The patch below fixes this bug, but this segfault should not occur.
Could you send in my mailbox an input file which crashes mp4h?

--- input.c     2000/06/22 20:23:03     1.36
+++ input.c     2000/06/23 20:00:52
@@ -1062,7 +1062,8 @@
       else if (expansion == READ_BODY)
         {
           obstack_1grow (&token_stack, ch);
-          while ((ch = next_char ()) != CHAR_EOF && ! IS_ESCAPE(ch))
+          while ((ch = next_char ()) != CHAR_EOF
+                  && ! IS_ESCAPE(ch) && ! IS_CLOSE (ch))
             {
               if (eolcomm.length > 0 && MATCH (ch, eolcomm.string))
                 {

-- 
Denis Barbier
WML Maintainer
______________________________________________________________________
Website META Language (WML)                www.engelschall.com/sw/wml/
Official Support Mailing List                   sw-wml@engelschall.com
Automated List Manager                       majordomo@engelschall.com