[Date Index][Thread Index]
[Date Prev][Date Next][Thread Prev][Thread Next]

Re: possible patch to WML



On Wed, Oct 04, 2000 at 08:28:50PM -0500, Wayne Schlitt wrote:

> Hi.
> 
> I'm a newbie web designer, and a newbie to WML, so there may be good
> reasons why WML works the way it does, but I would like to propose a
> patch anyway:

Hi Wayne, sorry for this late answer.

[...]
> Basically, all this patch does is let you *not* set the text, link, alink
> and vlink colors on the <body> tag.  You have always been able to skip 
> setting the bgcolor by specifying the color "none", this just extends
> that functionality.
> 
> I have been told that if you set one of these, you should set all
> because you don't know how the user has set up their defaults on their 
> browswer and your choice of colors may be bad for what they have
> choosen.

This remark is fully right, it is why i will use a modified version of
your patch. A new ``color=none'' attribute prevents setting bgcolor,
text, link, alink and vlink attributes.

diff -u -r1.15 page.src
--- page.src	2000/08/03 21:47:26	1.15
+++ page.src	2000/10/23 20:44:22
@@ -18,7 +18,7 @@
 #   the new PAGE tag
 #
 <define-tag page>
-<preserve title indent info background bgcolor text link alink vlink
+<preserve title indent info background color bgcolor text link alink vlink
           onload slices />
 <set-var info=* />
 <set-var slices=* />
@@ -32,11 +32,13 @@
 {#WML_PAGE_HEAD_<get-var __std_page_cnt />#}\
 </head*>
 <body*<if <get-var background /> " background=\"<get-var background />\"" "" />\
+      <when <not <get-var color /> />>\
       <if <get-var bgcolor /> <group <ifeq "<get-var bgcolor />" "none" "" " bgcolor=\"<get-var bgcolor />\"" /> /> " bgcolor=\"#ffffff\"" />\
       <if <get-var text /> " text=\"<get-var text />\"" " text=\"#000000\"" />\
       <if <get-var link /> " link=\"<get-var link />\"" " link=\"#333399\"" />\
       <if <get-var alink /> " alink=\"<get-var alink />\"" " alink=\"#9999ff\"" />\
       <if <get-var vlink /> " vlink=\"<get-var vlink />\"" " vlink=\"#000066\"" />\
+      </when>\
       <if <get-var onload /> " onload=\"<get-var onload />\"" "" />\
 >
 <set-var __i=0 />
@@ -54,7 +56,7 @@
 </body*>
 </html*><ifeq "<get-var slices />" "" ":WML_STDPAGE_FOOT]" />
 {#WML_PAGE_BODY_<get-var __std_page_cnt />#:\
-<restore  title indent info background bgcolor text link alink vlink
+<restore  title indent info background color bgcolor text link alink vlink
           onload slices />
 </define-tag>
 
Thanks for your suggestion.

-- 
Denis Barbier
WML Maintainer
______________________________________________________________________
Website META Language (WML)                www.engelschall.com/sw/wml/
Official Support Mailing List                   sw-wml@engelschall.com
Automated List Manager                       majordomo@engelschall.com